Daniel Kinzler has uploaded a new change for review. Change subject: ORMRow must not ignore failures on insert by deault. ......................................................................
ORMRow must not ignore failures on insert by deault. ORMRow shouldn't apply the "IGNORE" modifier for insertions by default. IGNORE means pretending the insert was successfull even if it wasn't. That's not a good default, and for some databases (like sqlite), may actually hide errors beyond key conflicts. Change-Id: I8b00cd03a459419441195ed25091385371b027a5 --- M includes/db/ORMRow.php M includes/site/SitesTable.php M tests/phpunit/includes/db/TestORMRowTest.php 3 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/15/31015/1 -- To view, visit https://gerrit.wikimedia.org/r/31015 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b00cd03a459419441195ed25091385371b027a5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
