Aaron Schulz has submitted this change and it was merged. Change subject: ORMRow must not ignore failures on insert by deault. ......................................................................
ORMRow must not ignore failures on insert by deault. ORMRow shouldn't apply the "IGNORE" modifier for insertions by default. IGNORE means pretending the insert was successfull even if it wasn't. That's not a good default, and for some databases (like sqlite), may actually hide errors beyond key conflicts. Change-Id: I8b00cd03a459419441195ed25091385371b027a5 --- M includes/db/ORMRow.php M includes/site/SitesTable.php M tests/phpunit/includes/db/ORMRowTest.php M tests/phpunit/includes/db/TestORMRowTest.php M tests/phpunit/includes/site/SiteObjectTest.php 5 files changed, 20 insertions(+), 5 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/31015 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b00cd03a459419441195ed25091385371b027a5 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Demon <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Reedy <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
