Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/176218

Change subject: SkinFallbackTemplate: Remove outdated @todo
......................................................................

SkinFallbackTemplate: Remove outdated @todo

It was already implemented

Change-Id: I74d326b60c19bbee67e83980fa47ecbb26250359
---
M includes/skins/SkinFallbackTemplate.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/18/176218/1

diff --git a/includes/skins/SkinFallbackTemplate.php 
b/includes/skins/SkinFallbackTemplate.php
index ea94fad..0d072ab 100644
--- a/includes/skins/SkinFallbackTemplate.php
+++ b/includes/skins/SkinFallbackTemplate.php
@@ -17,7 +17,7 @@
         * @return array
         */
        private function findInstalledSkins() {
-               $styleDirectory = $this->config->get( 'StyleDirectory' ); // 
@todo we should inject this directly?
+               $styleDirectory = $this->config->get( 'StyleDirectory' );
                // Get all subdirectories which might contains skins
                $possibleSkins = scandir( $styleDirectory );
                $possibleSkins = array_filter( $possibleSkins, function ( 
$maybeDir ) use ( $styleDirectory ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/176218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74d326b60c19bbee67e83980fa47ecbb26250359
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to