jenkins-bot has submitted this change and it was merged.
Change subject: SkinFallbackTemplate: Remove outdated @todo
......................................................................
SkinFallbackTemplate: Remove outdated @todo
It was already implemented
Change-Id: I74d326b60c19bbee67e83980fa47ecbb26250359
---
M includes/skins/SkinFallbackTemplate.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/skins/SkinFallbackTemplate.php
b/includes/skins/SkinFallbackTemplate.php
index ea94fad..0d072ab 100644
--- a/includes/skins/SkinFallbackTemplate.php
+++ b/includes/skins/SkinFallbackTemplate.php
@@ -17,7 +17,7 @@
* @return array
*/
private function findInstalledSkins() {
- $styleDirectory = $this->config->get( 'StyleDirectory' ); //
@todo we should inject this directly?
+ $styleDirectory = $this->config->get( 'StyleDirectory' );
// Get all subdirectories which might contains skins
$possibleSkins = scandir( $styleDirectory );
$possibleSkins = array_filter( $possibleSkins, function (
$maybeDir ) use ( $styleDirectory ) {
--
To view, visit https://gerrit.wikimedia.org/r/176218
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74d326b60c19bbee67e83980fa47ecbb26250359
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
