AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177594
Change subject: Don't insert banner for bots
......................................................................
Don't insert banner for bots
Change-Id: Id14c4981138c25b79e45f724844db1f15530ef6e
---
M modules/ext.centralNotice.bannerController/bannerController.js
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/94/177594/1
diff --git a/modules/ext.centralNotice.bannerController/bannerController.js
b/modules/ext.centralNotice.bannerController/bannerController.js
index 1ed85af..fd3c7e2 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.js
@@ -356,6 +356,10 @@
var url, targets, durations, cookieName, cookieVal, deleteOld,
now,
parsedCookie, bucket;
+ if ( navigator.userAgent.match (
/bot|googlebot|crawler|spider|robot|crawling/i ) ) {
+ return;
+ }
+
var impressionData = {
country: mw.centralNotice.data.country,
uselang: mw.config.get( 'wgUserLanguage' ),
--
To view, visit https://gerrit.wikimedia.org/r/177594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id14c4981138c25b79e45f724844db1f15530ef6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: AndyRussG <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
