jenkins-bot has submitted this change and it was merged.
Change subject: Don't insert banner for bots
......................................................................
Don't insert banner for bots
Change-Id: Id14c4981138c25b79e45f724844db1f15530ef6e
---
M modules/ext.centralNotice.bannerController/bannerController.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Awight: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.centralNotice.bannerController/bannerController.js
b/modules/ext.centralNotice.bannerController/bannerController.js
index 26891cd..fb2f671 100644
--- a/modules/ext.centralNotice.bannerController/bannerController.js
+++ b/modules/ext.centralNotice.bannerController/bannerController.js
@@ -356,6 +356,10 @@
var url, targets, durations, cookieName, cookieVal, deleteOld,
now,
parsedCookie, bucket;
+ if ( navigator.userAgent.match (
/bot|googlebot|crawler|spider|robot|crawling/i ) ) {
+ return;
+ }
+
var impressionData = {
country: mw.centralNotice.data.country,
uselang: mw.config.get( 'wgUserLanguage' ),
--
To view, visit https://gerrit.wikimedia.org/r/177627
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id14c4981138c25b79e45f724844db1f15530ef6e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: wmf_deploy
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Mwalker <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
