jenkins-bot has submitted this change and it was merged.
Change subject: Hygiene: Increase specificity of api interaction selectors and
remove !important
......................................................................
Hygiene: Increase specificity of api interaction selectors and remove !important
I looked around and the two prefixed id's appear to be enough to win,
but I'm not sure i found every possible place they are used. I also
grepped through most of the flow specific css after less processing
to verify that we hardly use id selectors unless its to increase
specificity, and everywhere except this just one id.
Bug: T76598
Change-Id: Ia16671cf9cdbcc3e545103790b55e1b9007d9556
---
M modules/styles/js.less
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/styles/js.less b/modules/styles/js.less
index 029afe0..8766113 100644
--- a/modules/styles/js.less
+++ b/modules/styles/js.less
@@ -22,9 +22,9 @@
}
// API interaction indicator
- .flow-api-inprogress {
+ div#content div#bodyContent & .flow-api-inprogress {
opacity: 0.5;
- cursor: wait !important;
+ cursor: wait;
}
// A preview version of a given block
@@ -34,8 +34,8 @@
color: @colorRegressive;
}
- .flow-preview-target-hidden {
- display: none !important;
+ div#content div#bodyContent & .flow-preview-target-hidden {
+ display: none;
}
// With JS, hide .flow-nojs & display .flow-js elements
--
To view, visit https://gerrit.wikimedia.org/r/177472
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia16671cf9cdbcc3e545103790b55e1b9007d9556
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
