Niharika29 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178204
Change subject: Fix REPLACE INTO by UPDATE which results in integrity
constraint violation when required!=true in form
......................................................................
Fix REPLACE INTO by UPDATE which results in integrity constraint violation when
required!=true in form
Change-Id: I4b39d399806aed63f1b1efbc07244f1290c12803
---
M src/Wikimania/Scholarship/Dao/Settings.php
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/wikimania-scholarships
refs/changes/04/178204/1
diff --git a/src/Wikimania/Scholarship/Dao/Settings.php
b/src/Wikimania/Scholarship/Dao/Settings.php
index 811a902..5300c90 100644
--- a/src/Wikimania/Scholarship/Dao/Settings.php
+++ b/src/Wikimania/Scholarship/Dao/Settings.php
@@ -51,8 +51,9 @@
public function updateSettings( array $settings ) {
// TODO: change schema to track user changing settings
$stmt = $this->dbh->prepare( self::concat(
- 'REPLACE INTO settings (setting_name, value)',
- 'VALUES (:name, :value)'
+ 'UPDATE settings
+ SET value = :value
+ WHERE setting_name = :name'
) );
try {
$this->dbh->beginTransaction();
--
To view, visit https://gerrit.wikimedia.org/r/178204
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b39d399806aed63f1b1efbc07244f1290c12803
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/wikimania-scholarships
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
