Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/178407
Change subject: mediawiki.loader: Remove optional params in mw.loader.implement
tests
......................................................................
mediawiki.loader: Remove optional params in mw.loader.implement tests
Follows-up Ic8d7efe49b5d. Kept in the previous change to ensure
those tests work either way.
Change-Id: I7e185db56e36fdfbb88c2d0938cdf55881e8c313
---
M tests/qunit/suites/resources/mediawiki/mediawiki.test.js
1 file changed, 11 insertions(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/07/178407/1
diff --git a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
index 140d7b8..f792059 100644
--- a/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
+++ b/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -381,7 +381,7 @@
isAwesomeDone = true;
};
- mw.loader.implement( 'test.callback', [QUnit.fixurl(
mw.config.get( 'wgScriptPath' ) +
'/tests/qunit/data/callMwLoaderTestCallback.js' )], {}, {} );
+ mw.loader.implement( 'test.callback', [QUnit.fixurl(
mw.config.get( 'wgScriptPath' ) +
'/tests/qunit/data/callMwLoaderTestCallback.js' )] );
mw.loader.using( 'test.callback', function () {
@@ -405,7 +405,7 @@
isAwesomeDone = true;
};
- mw.loader.implement( 'test.promise', [QUnit.fixurl(
mw.config.get( 'wgScriptPath' ) +
'/tests/qunit/data/callMwLoaderTestCallback.js' )], {}, {} );
+ mw.loader.implement( 'test.promise', [QUnit.fixurl(
mw.config.get( 'wgScriptPath' ) +
'/tests/qunit/data/callMwLoaderTestCallback.js' )] );
mw.loader.using( 'test.promise' )
.done( function () {
@@ -443,8 +443,7 @@
},
{
'all': '.mw-test-implement-a { float: right; }'
- },
- {}
+ }
);
mw.loader.load( [
@@ -506,8 +505,7 @@
urlStyleTest(
'.mw-test-implement-b3', 'float', 'right' )
]
}
- },
- {}
+ }
);
mw.loader.load( [
@@ -537,8 +535,7 @@
},
{
'all': '.mw-test-implement-c { float: right; }'
- },
- {}
+ }
);
mw.loader.load( [
@@ -575,8 +572,7 @@
{
'all': [urlStyleTest( '.mw-test-implement-d',
'float', 'right' )],
'print': [urlStyleTest(
'.mw-test-implement-d2', 'text-align', 'center' )]
- },
- {}
+ }
);
mw.loader.load( [
@@ -663,18 +659,15 @@
['test.module5', '0', ['test.module4']],
['test.module6', '0', ['test.module5']]
] );
- mw.loader.implement( 'test.module4', function () {
- }, {}, {} );
+ mw.loader.implement( 'test.module4', function () { } );
assert.strictEqual( mw.loader.getState( 'test.module4' ),
'ready', 'Expected "ready" state for test.module4' );
assert.strictEqual( mw.loader.getState( 'test.module5' ),
'registered', 'Expected "registered" state for test.module5' );
assert.strictEqual( mw.loader.getState( 'test.module6' ),
'registered', 'Expected "registered" state for test.module6' );
- mw.loader.implement( 'test.module6', function () {
- }, {}, {} );
+ mw.loader.implement( 'test.module6', function () {} );
assert.strictEqual( mw.loader.getState( 'test.module4' ),
'ready', 'Expected "ready" state for test.module4' );
assert.strictEqual( mw.loader.getState( 'test.module5' ),
'registered', 'Expected "registered" state for test.module5' );
assert.strictEqual( mw.loader.getState( 'test.module6' ),
'loaded', 'Expected "loaded" state for test.module6' );
- mw.loader.implement( 'test.module5', function () {
- }, {}, {} );
+ mw.loader.implement( 'test.module5', function () {} );
assert.strictEqual( mw.loader.getState( 'test.module4' ),
'ready', 'Expected "ready" state for test.module4' );
assert.strictEqual( mw.loader.getState( 'test.module5' ),
'ready', 'Expected "ready" state for test.module5' );
assert.strictEqual( mw.loader.getState( 'test.module6' ),
'ready', 'Expected "ready" state for test.module6' );
@@ -686,8 +679,7 @@
['test.module8', '0', ['test.module7']],
['test.module9', '0', ['test.module8']]
] );
- mw.loader.implement( 'test.module8', function () {
- }, {}, {} );
+ mw.loader.implement( 'test.module8', function () {} );
assert.strictEqual( mw.loader.getState( 'test.module7' ),
'registered', 'Expected "registered" state for test.module7' );
assert.strictEqual( mw.loader.getState( 'test.module8' ),
'loaded', 'Expected "loaded" state for test.module8' );
assert.strictEqual( mw.loader.getState( 'test.module9' ),
'registered', 'Expected "registered" state for test.module9' );
@@ -695,8 +687,7 @@
assert.strictEqual( mw.loader.getState( 'test.module7' ),
'missing', 'Expected "missing" state for test.module7' );
assert.strictEqual( mw.loader.getState( 'test.module8' ),
'error', 'Expected "error" state for test.module8' );
assert.strictEqual( mw.loader.getState( 'test.module9' ),
'error', 'Expected "error" state for test.module9' );
- mw.loader.implement( 'test.module9', function () {
- }, {}, {} );
+ mw.loader.implement( 'test.module9', function () {} );
assert.strictEqual( mw.loader.getState( 'test.module7' ),
'missing', 'Expected "missing" state for test.module7' );
assert.strictEqual( mw.loader.getState( 'test.module8' ),
'error', 'Expected "error" state for test.module8' );
assert.strictEqual( mw.loader.getState( 'test.module9' ),
'error', 'Expected "error" state for test.module9' );
--
To view, visit https://gerrit.wikimedia.org/r/178407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e185db56e36fdfbb88c2d0938cdf55881e8c313
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
