jenkins-bot has submitted this change and it was merged.
Change subject: Fix case insensitive string comparison for http header names
......................................................................
Fix case insensitive string comparison for http header names
As of RFC 2616 sec 4.2, http header names are case insensitive.
Change-Id: Ib72df2572f5a9c825c5b3ad7735126f3687aad79
---
M includes/OutputHandler.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tim Starling: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/OutputHandler.php b/includes/OutputHandler.php
index b0bbcdd..c6209ee 100644
--- a/includes/OutputHandler.php
+++ b/includes/OutputHandler.php
@@ -129,7 +129,8 @@
$headers = headers_list();
$foundVary = false;
foreach ( $headers as $header ) {
- if ( substr( $header, 0, 5 ) == 'Vary:' ) {
+ $headerName = strtolower( substr( $header, 0, 5 ) );
+ if ( $headerName == 'vary:' ) {
$foundVary = true;
break;
}
--
To view, visit https://gerrit.wikimedia.org/r/151282
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib72df2572f5a9c825c5b3ad7735126f3687aad79
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Taueres <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
