Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179388
Change subject: When Esc is pressed, don't close VE if a window is open
......................................................................
When Esc is pressed, don't close VE if a window is open
Bug: T78201
Change-Id: I59ac3669351638f6da8f685f5be481854153ad49
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/88/179388/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 06d8f02..a39caf9 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -468,6 +468,15 @@
// Parent method
ve.init.mw.ViewPageTarget.super.prototype.onDocumentKeyDown.apply(
this, arguments );
+ // HACK: don't close the editor if a window is open, because Escape
will close the window
+ if (
+ this.getSurface().getDialogs().getCurrentWindow() ||
+ this.getSurface().toolbarDialogs.getCurrentWindow() ||
+
this.getSurface().getContext().getInspectors().getCurrentWindow()
+ ) {
+ return;
+ }
+
if ( e.which === OO.ui.Keys.ESCAPE ) {
this.deactivate( false, 'navigate-read' );
e.preventDefault();
--
To view, visit https://gerrit.wikimedia.org/r/179388
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59ac3669351638f6da8f685f5be481854153ad49
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
