Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/179975
Change subject: Edit/view source tab: Do not hijack middle click to display
confirmation, only left click
......................................................................
Edit/view source tab: Do not hijack middle click to display confirmation, only
left click
Middle click is supposed to open the link in a new tab.
Bug: T78546
Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/75/179975/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 4854a82..9ee6414 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1059,7 +1059,7 @@
.click( this.onViewTabClick.bind( this ) );
$( '#ca-viewsource, #ca-edit' ).click( function ( e ) {
- if ( target.getSurface() && !target.deactivating ) {
+ if ( e.which === 1 && target.getSurface() &&
!target.deactivating ) {
target.editSource();
if (
target.getSurface().getModel().hasBeenModified() ) {
--
To view, visit https://gerrit.wikimedia.org/r/179975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
