jenkins-bot has submitted this change and it was merged.
Change subject: Edit/view source tab: Do not hijack middle click to display
confirmation, only left click
......................................................................
Edit/view source tab: Do not hijack middle click to display confirmation, only
left click
Middle click is supposed to open the link in a new tab.
Bug: T78546
Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
---
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 4854a82..5c1f820 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -1059,6 +1059,10 @@
.click( this.onViewTabClick.bind( this ) );
$( '#ca-viewsource, #ca-edit' ).click( function ( e ) {
+ if ( e.which !== 1 || e.shiftKey || e.altKey ||
e.ctrlKey || e.metaKey ) {
+ return;
+ }
+
if ( target.getSurface() && !target.deactivating ) {
target.editSource();
--
To view, visit https://gerrit.wikimedia.org/r/179975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I594f1dff072d54c0a8d7112a1eaa0c1c84d0ffc1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
