Dbrant has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/186101

Change subject: Fix crash when clicking images in Preview.
......................................................................

Fix crash when clicking images in Preview.

Bug: T87110
Change-Id: I64edc5d340147dd9b582171f851ad84eb837f266
---
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/01/186101/1

diff --git 
a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java 
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
index c6a4217..8a2da9f 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
@@ -28,6 +28,8 @@
 import org.wikipedia.page.LinkHandler;
 import org.wikipedia.page.PageActivity;
 
+import java.io.UnsupportedEncodingException;
+import java.net.URLDecoder;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Locale;
@@ -251,6 +253,13 @@
                     return parentActivity.getPageTitle().getSite();
                 }
             };
+            bridge.addListener("imageClicked", new 
CommunicationBridge.JSEventListener() {
+                @Override
+                public void onMessage(String messageType, JSONObject 
messagePayload) {
+                    // just give it a stub message handler
+                    // (images will not be clickable in Preview)
+                }
+            });
         }
 
         ViewAnimations.fadeIn(previewContainer, new Runnable() {

-- 
To view, visit https://gerrit.wikimedia.org/r/186101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I64edc5d340147dd9b582171f851ad84eb837f266
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to