jenkins-bot has submitted this change and it was merged.
Change subject: Fix crash when clicking images in Preview.
......................................................................
Fix crash when clicking images in Preview.
Bug: T87110
Change-Id: I64edc5d340147dd9b582171f851ad84eb837f266
---
M wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
BearND: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
index c6a4217..cbaf48c 100644
--- a/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
+++ b/wikipedia/src/main/java/org/wikipedia/editing/EditPreviewFragment.java
@@ -251,6 +251,13 @@
return parentActivity.getPageTitle().getSite();
}
};
+ bridge.addListener("imageClicked", new
CommunicationBridge.JSEventListener() {
+ @Override
+ public void onMessage(String messageType, JSONObject
messagePayload) {
+ // just give it a stub message handler
+ // (images will not be clickable in Preview)
+ }
+ });
}
ViewAnimations.fadeIn(previewContainer, new Runnable() {
--
To view, visit https://gerrit.wikimedia.org/r/186101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I64edc5d340147dd9b582171f851ad84eb837f266
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
