Hashar has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/186126

Change subject: Use array_merge instead of += as the latter doesn't always work
......................................................................

Use array_merge instead of += as the latter doesn't always work

In plus, existing keys have precedence. So many of the tests
and up not being registered or run.

Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
---
M TitleBlacklist.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TitleBlacklist 
refs/changes/26/186126/1

diff --git a/TitleBlacklist.php b/TitleBlacklist.php
index 1a2c8cf..c524d80 100644
--- a/TitleBlacklist.php
+++ b/TitleBlacklist.php
@@ -86,7 +86,7 @@
 $wgHooks['ArticleSaveComplete'][] = 'TitleBlacklistHooks::clearBlacklist';
 $wgHooks['UserCreateForm'][] = 'TitleBlacklistHooks::addOverrideCheckbox';
 $wgHooks['UnitTestsList'][] = function( &$files ) {
-       $files += glob( __DIR__ . '/tests/*Test.php' );
+       $files = array_merge( $files, glob( __DIR__ . '/tests/*Test.php' ) );
        return true;
 };
 $wgHooks['ScribuntoExternalLibraries'][] = function( $engine, array 
&$extraLibraries ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/186126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleBlacklist
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to