jenkins-bot has submitted this change and it was merged.
Change subject: Use array_merge instead of += as the latter doesn't always work
......................................................................
Use array_merge instead of += as the latter doesn't always work
In plus, existing keys have precedence. So many of the tests
and up not being registered or run.
Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
---
M TitleBlacklist.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/TitleBlacklist.php b/TitleBlacklist.php
index 1a2c8cf..c524d80 100644
--- a/TitleBlacklist.php
+++ b/TitleBlacklist.php
@@ -86,7 +86,7 @@
$wgHooks['ArticleSaveComplete'][] = 'TitleBlacklistHooks::clearBlacklist';
$wgHooks['UserCreateForm'][] = 'TitleBlacklistHooks::addOverrideCheckbox';
$wgHooks['UnitTestsList'][] = function( &$files ) {
- $files += glob( __DIR__ . '/tests/*Test.php' );
+ $files = array_merge( $files, glob( __DIR__ . '/tests/*Test.php' ) );
return true;
};
$wgHooks['ScribuntoExternalLibraries'][] = function( $engine, array
&$extraLibraries ) {
--
To view, visit https://gerrit.wikimedia.org/r/186126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TitleBlacklist
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
