Hashar has uploaded a new change for review.
https://gerrit.wikimedia.org/r/186127
Change subject: Use array_merge instead of += as the latter doesn't always work
......................................................................
Use array_merge instead of += as the latter doesn't always work
In plus, existing keys have precedence. So many of the tests
and up not being registered or run.
Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
---
M GlobalCssJs.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalCssJs
refs/changes/27/186127/1
diff --git a/GlobalCssJs.hooks.php b/GlobalCssJs.hooks.php
index 1792ae5..23431a6 100644
--- a/GlobalCssJs.hooks.php
+++ b/GlobalCssJs.hooks.php
@@ -142,7 +142,7 @@
* Load our unit tests
*/
public static function onUnitTestsList( array &$files ) {
- $files += glob( __DIR__ . '/tests/*Test.php' );
+ $files = array_merge( $files, glob( __DIR__ .
'/tests/*Test.php' ) );
return true;
}
--
To view, visit https://gerrit.wikimedia.org/r/186127
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb43de3e7e5016981a097d65b4f0b0abca8fa184
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalCssJs
Gerrit-Branch: master
Gerrit-Owner: Hashar <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
