jenkins-bot has submitted this change and it was merged. Change subject: Remove dir=auto from firstHeading ......................................................................
Remove dir=auto from firstHeading dir="auto" was added in r105854 and r105870. It happens to be useful for completely left-to-right titles in right-to-left wikis, but time and again the users complain about titles that are generally right-to-left, but begin with a left-to-right character, such as https://fa.wikipedia.org/wiki/3GP_%D9%88_3G2 This seems to cause more problems than it resolves. Some day we may have proper direction for titles. Until then we should probably go back to just displaytitle. Bug: T51093 Change-Id: Ibf408bc6c5d2f8c05667107a547b0b02e06de270 --- M includes/skins/SkinFallbackTemplate.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Krinkle: Looks good to me, but someone else must approve Fomafix: Looks good to me, but someone else must approve Nikerabbit: Looks good to me, approved Ebrahim: Looks good to me, but someone else must approve Huji: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/skins/SkinFallbackTemplate.php b/includes/skins/SkinFallbackTemplate.php index 0d072ab..9cb4ea0 100644 --- a/includes/skins/SkinFallbackTemplate.php +++ b/includes/skins/SkinFallbackTemplate.php @@ -91,7 +91,7 @@ </form> <div class="mw-body" role="main"> - <h1 class="firstHeading"><span dir="auto"><?php $this->html( 'title' ) ?></span></h1> + <h1 class="firstHeading"><?php $this->html( 'title' ) ?></h1> <div class="mw-body-content"> <?php $this->html( 'bodytext' ) ?> -- To view, visit https://gerrit.wikimedia.org/r/164735 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf408bc6c5d2f8c05667107a547b0b02e06de270 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 <[email protected]> Gerrit-Reviewer: Daniel Friesen <[email protected]> Gerrit-Reviewer: Ebrahim <[email protected]> Gerrit-Reviewer: Fomafix Gerrit-Reviewer: Huji <[email protected]> Gerrit-Reviewer: Jack Phoenix <[email protected]> Gerrit-Reviewer: Krinkle <[email protected]> Gerrit-Reviewer: Nikerabbit <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
