Christopher Johnson (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/187958
Change subject: update to upstream commit
02a05bf283e3b3109d02ec4ccb693ce61820fa82 2015-02-01
......................................................................
update to upstream commit 02a05bf283e3b3109d02ec4ccb693ce61820fa82 2015-02-01
fixes deprecation of PhabricatorCrumbView
adds null to selectFilter for AphrontSideNavFilterView in Sprint context
Change-Id: I0d9c9b3ec1c20972254fa28935364d14c8e9e678
---
M src/application/SprintApplication.php
M src/controller/SprintController.php
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint
refs/changes/58/187958/1
diff --git a/src/application/SprintApplication.php
b/src/application/SprintApplication.php
index c46673e..31095ab 100644
--- a/src/application/SprintApplication.php
+++ b/src/application/SprintApplication.php
@@ -16,7 +16,7 @@
}
public function getIconName() {
- return 'slowvote';
+ return 'fa-puzzle-piece';
}
public function getShortDescription() {
diff --git a/src/controller/SprintController.php
b/src/controller/SprintController.php
index 0b0b671..c3c660b 100644
--- a/src/controller/SprintController.php
+++ b/src/controller/SprintController.php
@@ -83,7 +83,7 @@
return $crumbs;
}
protected function buildSprintApplicationCrumbs($can_create) {
- $crumbs = $this->buildCrumbs('slowvote', $this->getApplicationURI());
+ $crumbs = $this->buildCrumbs('fa-bar-chart', $this->getApplicationURI());
$crumbs->addAction(
id(new PHUIListItemView())
@@ -98,13 +98,13 @@
$crumbs = array();
- $crumbs[] = id(new PhabricatorCrumbView())
+ $crumbs[] = id(new PHUICrumbView())
->setHref($uri)
->setAural($sprite)
->setIcon($sprite);
- $view = new PhabricatorCrumbsView();
+ $view = new PHUICrumbsView();
foreach ($crumbs as $crumb) {
$view->addCrumb($crumb);
}
@@ -115,7 +115,7 @@
public function buildIconNavView(PhabricatorProject $project) {
$id = $project->getID();
$nav = $this->buildSprintIconNavView($project);
- $nav->selectFilter("board/{$id}/");
+ $nav->selectFilter(null);
return $nav;
}
--
To view, visit https://gerrit.wikimedia.org/r/187958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d9c9b3ec1c20972254fa28935364d14c8e9e678
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
