Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/188689
Change subject: Revert "Always log timing data if secureConnectionStart is
available"
......................................................................
Revert "Always log timing data if secureConnectionStart is available"
Having a deliberate bias in the sampling weakens my confidence in the validity
of the timing data. Given current uncertainty about page load perf in
production, I'd like to revert this for now.
This reverts commit 88911246371e4c6b87e8d2b669acabdfd1e1063f.
Change-Id: I2778a7c9bd33892367b751bf9462382dcc6f0cf2
---
M modules/ext.navigationTiming.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/NavigationTiming
refs/changes/89/188689/1
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 2768669..53d37f3 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -180,7 +180,7 @@
// Ensure we run after loadEventEnd.
$( window ).load( function () {
setTimeout( function () {
- if ( inSample() || ( timing &&
timing.secureConnectionStart ) ) {
+ if ( inSample() ) {
emitNavigationTiming();
}
mw.hook( 'postEdit' ).add( emitSaveTiming );
--
To view, visit https://gerrit.wikimedia.org/r/188689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2778a7c9bd33892367b751bf9462382dcc6f0cf2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
