jenkins-bot has submitted this change and it was merged.
Change subject: Revert "Always log timing data if secureConnectionStart is
available"
......................................................................
Revert "Always log timing data if secureConnectionStart is available"
Having a deliberate bias in the sampling weakens my confidence in the validity
of the timing data. Given current uncertainty about page load perf in
production, I'd like to revert this for now.
This reverts commit 88911246371e4c6b87e8d2b669acabdfd1e1063f.
Change-Id: I2778a7c9bd33892367b751bf9462382dcc6f0cf2
---
M NavigationTiming.php
M modules/ext.navigationTiming.js
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Ori.livneh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/NavigationTiming.php b/NavigationTiming.php
index 09382d6..2b4a8af 100644
--- a/NavigationTiming.php
+++ b/NavigationTiming.php
@@ -49,6 +49,9 @@
)
);
+if ( !isset( $wgEventLoggingSchemas ) ) {
+ $wgEventLoggingSchemas = array();
+}
$wgEventLoggingSchemas += array(
'NavigationTiming' => 10785754,
'SaveTiming' => 10785299,
diff --git a/modules/ext.navigationTiming.js b/modules/ext.navigationTiming.js
index 2768669..53d37f3 100644
--- a/modules/ext.navigationTiming.js
+++ b/modules/ext.navigationTiming.js
@@ -180,7 +180,7 @@
// Ensure we run after loadEventEnd.
$( window ).load( function () {
setTimeout( function () {
- if ( inSample() || ( timing &&
timing.secureConnectionStart ) ) {
+ if ( inSample() ) {
emitNavigationTiming();
}
mw.hook( 'postEdit' ).add( emitSaveTiming );
--
To view, visit https://gerrit.wikimedia.org/r/188689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2778a7c9bd33892367b751bf9462382dcc6f0cf2
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/NavigationTiming
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
