Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/189521
Change subject: Emit position event before window transition, not after
......................................................................
Emit position event before window transition, not after
The position event is required because the scrollbars are hidden
but that happens and the start of the transition, not the end.
Bug: T88867
Change-Id: I6a0f15b9c95dee0ca315fd43afb2f0e557d786ec
---
M src/ui/actions/ve.ui.WindowAction.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/21/189521/1
diff --git a/src/ui/actions/ve.ui.WindowAction.js
b/src/ui/actions/ve.ui.WindowAction.js
index fb00791..736e3d5 100644
--- a/src/ui/actions/ve.ui.WindowAction.js
+++ b/src/ui/actions/ve.ui.WindowAction.js
@@ -65,7 +65,6 @@
windowManager.getWindow( name ).then( function ( win ) {
windowManager.openWindow( win, data ).then( function ( closing
) {
- surface.getView().emit( 'position' );
closing.then( function ( closed ) {
surface.getView().activate();
closed.then( function () {
@@ -77,6 +76,7 @@
win.executeAction( action );
}
} );
+ surface.getView().emit( 'position' );
} );
return true;
--
To view, visit https://gerrit.wikimedia.org/r/189521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a0f15b9c95dee0ca315fd43afb2f0e557d786ec
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
