jenkins-bot has submitted this change and it was merged.
Change subject: Emit position event before window transition, not after
......................................................................
Emit position event before window transition, not after
The position event is required because the scrollbars are hidden
but that happens and the start of the transition, not the end.
Bug: T88867
Change-Id: I6a0f15b9c95dee0ca315fd43afb2f0e557d786ec
---
M src/ui/actions/ve.ui.WindowAction.js
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/actions/ve.ui.WindowAction.js
b/src/ui/actions/ve.ui.WindowAction.js
index fb00791..797905d 100644
--- a/src/ui/actions/ve.ui.WindowAction.js
+++ b/src/ui/actions/ve.ui.WindowAction.js
@@ -64,8 +64,11 @@
}
windowManager.getWindow( name ).then( function ( win ) {
- windowManager.openWindow( win, data ).then( function ( closing
) {
- surface.getView().emit( 'position' );
+ var opening = windowManager.openWindow( win, data );
+
+ surface.getView().emit( 'position' );
+
+ opening.then( function ( closing ) {
closing.then( function ( closed ) {
surface.getView().activate();
closed.then( function () {
--
To view, visit https://gerrit.wikimedia.org/r/189521
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a0f15b9c95dee0ca315fd43afb2f0e557d786ec
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
