Nikerabbit has uploaded a new change for review.
https://gerrit.wikimedia.org/r/191580
Change subject: Convert yaml parse failures to exceptions
......................................................................
Convert yaml parse failures to exceptions
Change-Id: I03a114cb99bc2782c4de16f4321b34925cdf8286
---
M utils/TranslateYaml.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate
refs/changes/80/191580/1
diff --git a/utils/TranslateYaml.php b/utils/TranslateYaml.php
index 9d7d592..beace46 100644
--- a/utils/TranslateYaml.php
+++ b/utils/TranslateYaml.php
@@ -44,7 +44,13 @@
switch ( $wgTranslateYamlLibrary ) {
case 'phpyaml':
- return yaml_parse( $text );
+ $ret = yaml_parse( $text );
+ if ( $ret === false ) {
+ // Convert failures to exceptions
+ throw new InvalidArgumentException(
"Invalid Yaml string" );
+ }
+
+ return $ret
case 'spyc':
// Load the bundled version if not otherwise
available
--
To view, visit https://gerrit.wikimedia.org/r/191580
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I03a114cb99bc2782c4de16f4321b34925cdf8286
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
