jenkins-bot has submitted this change and it was merged.
Change subject: Add @uses annotations for View tests
......................................................................
Add @uses annotations for View tests
Change-Id: I03a759e6d40f157d2ef96b7212771b79db796fcb
---
M repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
M repo/tests/phpunit/includes/View/ClaimsViewTest.php
M repo/tests/phpunit/includes/View/EntityTermsViewTest.php
M repo/tests/phpunit/includes/View/EntityViewFactoryTest.php
M repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
M repo/tests/phpunit/includes/View/ItemViewTest.php
M repo/tests/phpunit/includes/View/PropertyViewTest.php
M repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
M repo/tests/phpunit/includes/View/SiteLinksViewTest.php
M repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
10 files changed, 55 insertions(+), 0 deletions(-)
Approvals:
Adrian Lang: Looks good to me, approved
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
JanZerebecki: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
index 21b1093..2750f94 100644
--- a/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimHtmlGeneratorTest.php
@@ -69,6 +69,9 @@
}
/**
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
* @dataProvider getHtmlForClaimProvider
*/
public function testGetHtmlForClaim(
diff --git a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
index 5097e0d..9908ac2 100644
--- a/repo/tests/phpunit/includes/View/ClaimsViewTest.php
+++ b/repo/tests/phpunit/includes/View/ClaimsViewTest.php
@@ -40,6 +40,12 @@
) );
}
+ /**
+ * @uses Wikibase\Repo\View\SectionEditLinkGenerator
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ */
public function testGetHtml() {
$propertyId = new PropertyId( 'P77' );
$claims = $this->makeClaims( $propertyId );
diff --git a/repo/tests/phpunit/includes/View/EntityTermsViewTest.php
b/repo/tests/phpunit/includes/View/EntityTermsViewTest.php
index 6eb1a23..75cc30a 100644
--- a/repo/tests/phpunit/includes/View/EntityTermsViewTest.php
+++ b/repo/tests/phpunit/includes/View/EntityTermsViewTest.php
@@ -14,6 +14,11 @@
/**
* @covers Wikibase\Repo\View\EntityTermsView
*
+ * @uses Wikibase\Repo\View\TextInjector
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseRepo
*
diff --git a/repo/tests/phpunit/includes/View/EntityViewFactoryTest.php
b/repo/tests/phpunit/includes/View/EntityViewFactoryTest.php
index 9eaf550..e87af70 100644
--- a/repo/tests/phpunit/includes/View/EntityViewFactoryTest.php
+++ b/repo/tests/phpunit/includes/View/EntityViewFactoryTest.php
@@ -12,6 +12,20 @@
/**
* @covers \Wikibase\Repo\View\EntityViewFactory
*
+ * @uses Wikibase\Repo\View\ClaimHtmlGenerator
+ * @uses Wikibase\Repo\View\EntityTermsView
+ * @uses Wikibase\Repo\View\EntityView
+ * @uses Wikibase\Repo\View\ItemView
+ * @uses Wikibase\Repo\View\PropertyView
+ * @uses Wikibase\Repo\View\SectionEditLinkGenerator
+ * @uses Wikibase\Repo\View\SiteLinksView
+ * @uses Wikibase\Repo\View\StatementGroupListView
+ * @uses Wikibase\Repo\View\SnakHtmlGenerator
+ * @uses Wikibase\Repo\View\TextInjector
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @licence GNU GPL v2+
* @author Katie Filbert < [email protected] >
*/
diff --git
a/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
b/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
index cc4c9c7..8fa8d4a 100644
--- a/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
+++ b/repo/tests/phpunit/includes/View/EntityViewPlaceholderExpanderTest.php
@@ -18,6 +18,11 @@
/**
* @covers Wikibase\Repo\View\EntityViewPlaceholderExpander
*
+ * @uses Wikibase\Repo\View\EntityTermsView
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseRepo
* @group EntityView
diff --git a/repo/tests/phpunit/includes/View/ItemViewTest.php
b/repo/tests/phpunit/includes/View/ItemViewTest.php
index 2ab91b5..8475c9c 100644
--- a/repo/tests/phpunit/includes/View/ItemViewTest.php
+++ b/repo/tests/phpunit/includes/View/ItemViewTest.php
@@ -13,6 +13,11 @@
* @covers Wikibase\Repo\View\ItemView
* @covers Wikibase\Repo\View\EntityView
*
+ * @uses Wikibase\Repo\View\TextInjector
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseItemView
*
diff --git a/repo/tests/phpunit/includes/View/PropertyViewTest.php
b/repo/tests/phpunit/includes/View/PropertyViewTest.php
index 9eb5691..bcea249 100644
--- a/repo/tests/phpunit/includes/View/PropertyViewTest.php
+++ b/repo/tests/phpunit/includes/View/PropertyViewTest.php
@@ -17,6 +17,11 @@
* @covers Wikibase\Repo\View\PropertyView
* @covers Wikibase\Repo\View\EntityView
*
+ * @uses Wikibase\Repo\View\TextInjector
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibasePropertyView
*
diff --git a/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
b/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
index 99e34bd..04c5cb7 100644
--- a/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/SectionEditLinkGeneratorTest.php
@@ -12,6 +12,10 @@
/**
* @covers Wikibase\Repo\View\SectionEditLinkGenerator
*
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseRepo
* @group EntityView
diff --git a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
index f999e72..3c2a13b 100644
--- a/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
+++ b/repo/tests/phpunit/includes/View/SiteLinksViewTest.php
@@ -20,6 +20,10 @@
/**
* @covers Wikibase\Repo\View\SiteLinksView
*
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseRepo
*
diff --git a/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
b/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
index 12b5e2b..ae0a72c 100644
--- a/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
+++ b/repo/tests/phpunit/includes/View/SnakHtmlGeneratorTest.php
@@ -18,6 +18,10 @@
/**
* @covers Wikibase\Repo\View\SnakHtmlGenerator
*
+ * @uses Wikibase\Template\Template
+ * @uses Wikibase\Template\TemplateFactory
+ * @uses Wikibase\Template\TemplateRegistry
+ *
* @group Wikibase
* @group WikibaseRepo
*
--
To view, visit https://gerrit.wikimedia.org/r/191054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03a759e6d40f157d2ef96b7212771b79db796fcb
Gerrit-PatchSet: 8
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Lang <[email protected]>
Gerrit-Reviewer: Adrian Lang <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
