Amire80 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/192730
Change subject: [BrowserTest] Update the scenario for Cite screenshot
......................................................................
[BrowserTest] Update the scenario for Cite screenshot
This screenshot only needs the "Cite" button,
and not the whole dropdown menu.
* The clicking step is removed.
* The element is reconfigured.
Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
---
M modules/ve-mw/tests/browser/features/language_screenshot.feature
M modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
M
modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
M modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
4 files changed, 7 insertions(+), 11 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/30/192730/1
diff --git a/modules/ve-mw/tests/browser/features/language_screenshot.feature
b/modules/ve-mw/tests/browser/features/language_screenshot.feature
index 5d403c7..ca22bd3 100644
--- a/modules/ve-mw/tests/browser/features/language_screenshot.feature
+++ b/modules/ve-mw/tests/browser/features/language_screenshot.feature
@@ -102,8 +102,7 @@
@language_screenshot
Scenario: VisualEditor_Cite_Pulldown
Given I am editing the language screenshots page
- When I click on Cite menu
- Then I should see Cite dropdown menu
+ Then I should see the Cite button
Scenario: VisualEditor_References_icon
Given I go to "Reference VisualEditor Screenshot" page which has references
@@ -112,7 +111,7 @@
Scenario: VisualEditor_References_edit
Given I go to the "Reference VisualEditor Screenshot" page with source
content "VisualEditor is a MediaWiki extension"
- And I click on Cite menu
+ And I click the Cite button
When I click on Basic Reference in Cite menu dropdown
Then I should see Basic Reference dialog box
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
index e09cd93..e9a083c 100644
--- a/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
+++ b/modules/ve-mw/tests/browser/features/step_definitions/cite_steps.rb
@@ -1,7 +1,3 @@
-Given(/^I click the Cite button$/) do
- on(VisualEditorPage).cite_button_element.when_present.click
-end
-
Given(/^I can see the Cite User Interface$/) do
on(VisualEditorPage).cite_select_element.when_present
end
diff --git
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
index d600355..377185c 100644
---
a/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
+++
b/modules/ve-mw/tests/browser/features/step_definitions/language_screenshot_steps.rb
@@ -347,12 +347,13 @@
)
end
-Then(/^I should see Cite dropdown menu$/) do
- on(VisualEditorPage).cite_pull_down_element.when_present.should be_visible
+Then(/^I should see the Cite button$/) do
+ on(VisualEditorPage).cite_button_element.when_present.should be_visible
+ Screenshot.zoom_browser(@browser, 3)
Screenshot.capture(
@browser,
"#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png",
- [@current_page.cite_pull_down_element,
@current_page.cite_indicator_down_element]
+ [@current_page.cite_button_element]
)
end
diff --git
a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
index 1d537a4..dd92673 100644
--- a/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
+++ b/modules/ve-mw/tests/browser/features/support/pages/visual_editor_page.rb
@@ -22,7 +22,7 @@
div(:cite_basic_options_area, class: 'oo-ui-layout oo-ui-iconElement
oo-ui-labelElement oo-ui-fieldsetLayout')
span(:cite_basic_reference, css: '.oo-ui-icon-reference')
a(:cite_book, css: '.oo-ui-tool-name-cite-book > a:nth-child(1)')
- span(:cite_button, css: '.ve-test-toolbar-cite .oo-ui-labelElement-label')
+ div(:cite_button, class: 've-test-toolbar-cite')
text_field(:cite_custom_field_name, css: '.oo-ui-searchWidget-query >
div:nth-child(1) > input:nth-child(1)')
text_field(:cite_group_name_textarea, css:
'div.oo-ui-indicatorElement:nth-child(1) > input:nth-child(1)')
a(:cite_journal, css: '.oo-ui-tool-name-cite-journal > a:nth-child(1)')
--
To view, visit https://gerrit.wikimedia.org/r/192730
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4b863e51db611b96186ca6381d0426a335a9a17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
