Matthias Mullie has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/193093

Change subject: Fix fatal on topic history
......................................................................

Fix fatal on topic history

$historyLink is an Anchor object, which is passed as param to
a Message (which assumes a string)
This throws a catchable fatal, since it can't convert Anchor
into string.

Change-Id: Ibba2f391b66adf6f86aa165250a0665cfe94396e
---
M includes/Templating.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/93/193093/1

diff --git a/includes/Templating.php b/includes/Templating.php
index ff5beda..1251c36 100644
--- a/includes/Templating.php
+++ b/includes/Templating.php
@@ -165,6 +165,7 @@
                        }
 
                        $historyLink = 
$this->urlGenerator->workflowHistoryLink( null, 
$revision->getRootPost()->getPostId() );
+                       $historyLink = $historyLink->getLinkURL();
 
                        // Messages: flow-hide-post-content, 
flow-delete-post-content, flow-suppress-post-content
                        //           flow-hide-title-content, 
flow-delete-title-content, flow-suppress-title-content

-- 
To view, visit https://gerrit.wikimedia.org/r/193093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibba2f391b66adf6f86aa165250a0665cfe94396e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to