jenkins-bot has submitted this change and it was merged.
Change subject: Fix fatal on topic history
......................................................................
Fix fatal on topic history
$historyLink is an Anchor object, which is passed as param to
a Message (which assumes a string)
This throws a catchable fatal, since it can't convert Anchor
into string.
Change-Id: Ibba2f391b66adf6f86aa165250a0665cfe94396e
---
M includes/Templating.php
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Templating.php b/includes/Templating.php
index ff5beda..3393dad 100644
--- a/includes/Templating.php
+++ b/includes/Templating.php
@@ -164,7 +164,9 @@
$type = 'title';
}
- $historyLink =
$this->urlGenerator->workflowHistoryLink( null,
$revision->getRootPost()->getPostId() );
+ $historyLink = $this->urlGenerator
+ ->workflowHistoryLink( null,
$revision->getRootPost()->getPostId() )
+ ->getLinkURL();
// Messages: flow-hide-post-content,
flow-delete-post-content, flow-suppress-post-content
// flow-hide-title-content,
flow-delete-title-content, flow-suppress-title-content
--
To view, visit https://gerrit.wikimedia.org/r/193093
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibba2f391b66adf6f86aa165250a0665cfe94396e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: SG <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
