jenkins-bot has submitted this change and it was merged.
Change subject: Stop bogus emits from handleLinearDelete
......................................................................
Stop bogus emits from handleLinearDelete
Previously, an autoselecting surface fragment was triggering bogus select
events. The content for deletion was first programmatically selected in the
fragment, and that selection was leaking out into emit events.
Bug: T90478
Bug: T92286
Change-Id: Ieef29df406b883a0578029a1cb7242b99033cc13
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index cac7061..b959409 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3275,7 +3275,7 @@
}
}
- this.getModel().getLinearFragment( rangeToRemove ).delete( direction );
+ this.getModel().getLinearFragment( rangeToRemove, true ).delete(
direction ).select();
// Rerender selection even if it didn't change
// TODO: is any of this necessary?
this.focus();
--
To view, visit https://gerrit.wikimedia.org/r/196224
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieef29df406b883a0578029a1cb7242b99033cc13
Gerrit-PatchSet: 5
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Divec <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
