Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/196314
Change subject: Stop bogus emits from handleLinearDelete
......................................................................
Stop bogus emits from handleLinearDelete
Previously, an autoselecting surface fragment was triggering bogus select
events. The content for deletion was first programmatically selected in the
fragment, and that selection was leaking out into emit events.
Bug: T90478
Bug: T92286
Change-Id: Ieef29df406b883a0578029a1cb7242b99033cc13
(cherry picked from commit 24fe9109166325dcd7d89797bf9fabd97b8f749a)
---
M src/ce/ve.ce.Surface.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/14/196314/1
diff --git a/src/ce/ve.ce.Surface.js b/src/ce/ve.ce.Surface.js
index cac7061..b959409 100644
--- a/src/ce/ve.ce.Surface.js
+++ b/src/ce/ve.ce.Surface.js
@@ -3275,7 +3275,7 @@
}
}
- this.getModel().getLinearFragment( rangeToRemove ).delete( direction );
+ this.getModel().getLinearFragment( rangeToRemove, true ).delete(
direction ).select();
// Rerender selection even if it didn't change
// TODO: is any of this necessary?
this.focus();
--
To view, visit https://gerrit.wikimedia.org/r/196314
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieef29df406b883a0578029a1cb7242b99033cc13
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: wmf/1.25wmf21
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
