Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/197996
Change subject: Log more information when bad <ref> is encountered
......................................................................
Log more information when bad <ref> is encountered
Change-Id: Ie26adfe8cdba60389e70eb2ee88398ccc7f38c0e
---
M lib/mediawiki.WikitextSerializer.js
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/96/197996/1
diff --git a/lib/mediawiki.WikitextSerializer.js
b/lib/mediawiki.WikitextSerializer.js
index 19614fa..a070f65 100644
--- a/lib/mediawiki.WikitextSerializer.js
+++ b/lib/mediawiki.WikitextSerializer.js
@@ -578,11 +578,24 @@
if (bodyElt) {
htmlText = bodyElt.innerHTML;
} else {
+<<<<<<< Updated upstream
// Bail out of here since we cannot
meaningfully recover
// from this without losing content and
corrupting the page.
state.env.log("fatal",
"extension src id points to
non-existent element for: ",
node.outerHTML);
+=======
+ // Some extra debugging for VisualEditor
+ var extraDebug = '';
+ var firstA =
node.querySelector('a[href]');
+ if
(/^#/.test(firstA.getAttribute('href'))) {
+ var ref =
node.ownerDocument.querySelector(firstA.getAttribute('href'));
+ extraDebug = ref ? '
[reference: '+ref.outerHTML+']' :
+ ' [reference
'+firstA.getAttribute('href')+' not found]';
+ }
+ this.env.log("error",
+ "extension src id points to
non-existent element for: " + node.outerHTML + extraDebug);
+>>>>>>> Stashed changes
}
}
if (htmlText) {
--
To view, visit https://gerrit.wikimedia.org/r/197996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie26adfe8cdba60389e70eb2ee88398ccc7f38c0e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
