jenkins-bot has submitted this change and it was merged.
Change subject: Log more information when bad <ref> is encountered
......................................................................
Log more information when bad <ref> is encountered
Change-Id: Ie26adfe8cdba60389e70eb2ee88398ccc7f38c0e
---
M lib/mediawiki.WikitextSerializer.js
1 file changed, 18 insertions(+), 1 deletion(-)
Approvals:
Cscott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/mediawiki.WikitextSerializer.js
b/lib/mediawiki.WikitextSerializer.js
index 19614fa..c84a4a2 100644
--- a/lib/mediawiki.WikitextSerializer.js
+++ b/lib/mediawiki.WikitextSerializer.js
@@ -578,11 +578,28 @@
if (bodyElt) {
htmlText = bodyElt.innerHTML;
} else {
+ // Some extra debugging for VisualEditor
+ var extraDebug = '', ref, href,
+ firstA =
node.querySelector('a[href]');
+ if (firstA &&
/^#/.test(firstA.getAttribute('href'))) {
+ href =
firstA.getAttribute('href');
+ ref =
node.ownerDocument.querySelector(href);
+ if (ref) {
+ extraDebug += ' [own
doc: '+ref.outerHTML+']';
+ }
+ ref =
state.env.page.dom.ownerDocument.querySelector(href);
+ if (ref) {
+ extraDebug += ' [main
doc: '+ref.outerHTML+']';
+ }
+ if (!extraDebug) {
+ extraDebug = '
[reference '+href+' not found]';
+ }
+ }
// Bail out of here since we cannot
meaningfully recover
// from this without losing content and
corrupting the page.
state.env.log("fatal",
"extension src id points to
non-existent element for: ",
- node.outerHTML);
+ node.outerHTML + extraDebug);
}
}
if (htmlText) {
--
To view, visit https://gerrit.wikimedia.org/r/197996
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie26adfe8cdba60389e70eb2ee88398ccc7f38c0e
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
