jenkins-bot has submitted this change and it was merged.

Change subject: build: Declare grunt-cli dependency
......................................................................


build: Declare grunt-cli dependency

A long time ago, npm did not support using command line programs
within 'npm test' (not unless harcoding a path to node_modules/bin/...
within packages.json/scripts/test). But this has been long supported.

Declaring a (dev)dependency will provide its binaries to the
PATH used by the subshell 'npm test' creates internally.

Add grunt-cli so that developers don't have to manually install it.

Change-Id: I6a7fafa3c6e40d2407f07c514167ab9fc7661685
(cherry picked from commit fa4ba8dbd7519a817dad75994ed31a3fc34c6f96)
---
M package.json
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Krinkle: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/package.json b/package.json
index 076582b..933212c 100644
--- a/package.json
+++ b/package.json
@@ -8,6 +8,7 @@
   },
   "devDependencies": {
     "grunt": "0.4.5",
+    "grunt-cli": "0.1.13",
     "grunt-banana-checker": "0.2.0",
     "grunt-contrib-copy": "0.8.0",
     "grunt-contrib-jshint": "0.11.0",

-- 
To view, visit https://gerrit.wikimedia.org/r/198264
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6a7fafa3c6e40d2407f07c514167ab9fc7661685
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.25wmf21
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to