Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201304
Change subject: Add JSCS configuration and hook it up to `npm test` (via grunt)
......................................................................
Add JSCS configuration and hook it up to `npm test` (via grunt)
Change-Id: Ibf0e7b35c3ba066d22664accd457a2639dccc18e
---
M .gitignore
A .jscsrc
A .jshintignore
M .jshintrc
A Gruntfile.js
A package.json
6 files changed, 64 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection
refs/changes/04/201304/1
diff --git a/.gitignore b/.gitignore
index 98b092a..93f1361 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,2 @@
-.svn
-*~
-*.kate-swp
-.*.swp
+node_modules
+npm-debug.log
diff --git a/.jscsrc b/.jscsrc
new file mode 100644
index 0000000..966374c
--- /dev/null
+++ b/.jscsrc
@@ -0,0 +1,7 @@
+{
+ "preset": "wikimedia",
+ // allow some slop to account for legacy code
+ "requireCamelCaseOrUpperCaseIdentifiers": null,
+ "requireMultipleVarDecl": true,
+ "disallowQuotedKeysInObjects": null
+}
diff --git a/.jshintignore b/.jshintignore
new file mode 100644
index 0000000..3c3629e
--- /dev/null
+++ b/.jshintignore
@@ -0,0 +1 @@
+node_modules
diff --git a/.jshintrc b/.jshintrc
index 9801113..61e5732 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -15,6 +15,8 @@
"globals": {
"jQuery": false,
- "mw": false
+ "mw": false,
+ "OO": false,
+ "JSON": false
}
}
diff --git a/Gruntfile.js b/Gruntfile.js
new file mode 100644
index 0000000..f019781
--- /dev/null
+++ b/Gruntfile.js
@@ -0,0 +1,33 @@
+/*!
+ * Grunt file
+ */
+
+/*jshint node:true */
+module.exports = function ( grunt ) {
+ grunt.loadNpmTasks( 'grunt-contrib-jshint' );
+ grunt.loadNpmTasks( 'grunt-jscs' );
+
+ grunt.initConfig( {
+ pkg: grunt.file.readJSON( 'package.json' ),
+ // Lint – Code
+ jshint: {
+ options: {
+ jshintrc: true
+ },
+ dev: [
+ '*.js',
+ 'modules/**/*.js'
+ ]
+ },
+ jscs: {
+ dev: [
+ '<%= jshint.dev %>'
+ ]
+ }
+ } );
+
+ grunt.registerTask( 'lint', [ 'jshint', 'jscs' ] );
+ grunt.registerTask( 'test', [ 'lint' ] );
+
+ grunt.registerTask( 'default', 'test' );
+};
diff --git a/package.json b/package.json
new file mode 100644
index 0000000..de2d5be
--- /dev/null
+++ b/package.json
@@ -0,0 +1,18 @@
+{
+ "name": "wikimedia-collection",
+ "version": "0.0.0",
+ "description": "Mediawiki Collection extension",
+ "scripts": {
+ "test": "grunt test"
+ },
+ "repository": {
+ "type": "git",
+ "url": "https://gerrit.wikimedia.org/r/p/mediawiki/extensions/Collection";
+ },
+ "license": "GPLv2",
+ "dependencies": {
+ "grunt": "^0.4.5",
+ "grunt-contrib-jshint": "^0.11.1",
+ "grunt-jscs": "^1.6.0"
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/201304
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf0e7b35c3ba066d22664accd457a2639dccc18e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
