Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/201318
Change subject: WIP Don't overwrite normalized data with unstaged
......................................................................
WIP Don't overwrite normalized data with unstaged
To access results of an unstaging operation, please use
GatewayAdapter::getData_Unstaged_Escaped()
instead of assuming that normalized data was updated.
Change-Id: Ifda87f5b596d7381e113b6d0df1551191f89c85b
TODO: Check what assumptions are made by calling code when using unstaged data.
---
M gateway_common/gateway.adapter.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/18/201318/1
diff --git a/gateway_common/gateway.adapter.php
b/gateway_common/gateway.adapter.php
index 5ab6582..d9430af 100644
--- a/gateway_common/gateway.adapter.php
+++ b/gateway_common/gateway.adapter.php
@@ -578,8 +578,6 @@
}
$this->unstageData();
-
- $this->dataObj->addData( $this->unstaged_data );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/201318
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifda87f5b596d7381e113b6d0df1551191f89c85b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
