Pastakhov has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202017
Change subject: fix readonly state and TextSelection (v 3.1.2)
......................................................................
fix readonly state and TextSelection (v 3.1.2)
Bug: T95149
Bug: T95150
Change-Id: Ia8660d5c2a6dca6a2a37bc60e36620f48aad3260
---
M CodeMirror.php
M resources/ext.CodeMirror.js
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeMirror
refs/changes/17/202017/1
diff --git a/CodeMirror.php b/CodeMirror.php
index 4477e17..9df0571 100644
--- a/CodeMirror.php
+++ b/CodeMirror.php
@@ -15,7 +15,7 @@
die( 'This file is an extension to MediaWiki and thus not a valid entry
point.' );
}
-const EXT_CODEMIRROR_VERSION = '3.1.1';
+const EXT_CODEMIRROR_VERSION = '3.1.2';
// Register this extension on Special:Version
$wgExtensionCredits['parserhook'][] = array(
diff --git a/resources/ext.CodeMirror.js b/resources/ext.CodeMirror.js
index 69160e7..3d6b3cb 100644
--- a/resources/ext.CodeMirror.js
+++ b/resources/ext.CodeMirror.js
@@ -7,7 +7,7 @@
api = new mw.Api(),
// function for a textselection function for CodeMirror
cmTextSelection = function ( command, options ) {
- if ( !codeMirror ) {
+ if ( !codeMirror || codeMirror.getTextArea() !==
this[0] ) {
return origTextSelection( command, options );
}
var fn, retval;
@@ -295,6 +295,7 @@
mwextModes: mw.config.get(
'extCodeMirrorExtModes' ),
styleActiveLine: true,
lineWrapping: true,
+ readOnly: textbox1[0].readOnly,
// select mediawiki as text input mode
mode: 'text/mediawiki'
} );
--
To view, visit https://gerrit.wikimedia.org/r/202017
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8660d5c2a6dca6a2a37bc60e36620f48aad3260
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeMirror
Gerrit-Branch: master
Gerrit-Owner: Pastakhov <pastak...@yandex.ru>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
