[MediaWiki-commits] [Gerrit] Also check wbIsEditView before enabling editing js - change (mediawiki...Wikibase)

[Aude (Code Review)]

Aude has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/202691

Change subject: Also check wbIsEditView before enabling editing js
......................................................................

Also check wbIsEditView before enabling editing js

this is added in ViewEntityAction and checks if
the page is a diff or not current.

Change-Id: I9713fb75408dc0c8d2ff31ec9de42bbb4dcf9a0b
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/91/202691/1

diff --git a/repo/resources/wikibase.ui.entityViewInit.js 
b/repo/resources/wikibase.ui.entityViewInit.js
index 9d5d7d8..475617c 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -16,7 +16,8 @@
 
                var $entityview = $( '.wikibase-entityview' );
                var entityInitializer = new wb.EntityInitializer( 'wbEntity' );
-               var canEdit = !mw.config.get( 'wbUserIsBlocked' ) && 
mw.config.get( 'wbUserCanEdit' );
+               var canEdit = !mw.config.get( 'wbUserIsBlocked' ) && 
mw.config.get( 'wbUserCanEdit' )
+                       && mw.config.get( 'wbIsEditView' );
 
                if( canEdit ) {
                        initToolbarController( $entityview );

-- 
To view, visit https://gerrit.wikimedia.org/r/202691
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9713fb75408dc0c8d2ff31ec9de42bbb4dcf9a0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: wmf/1.25wmf24
Gerrit-Owner: Aude <aude.w...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits