jenkins-bot has submitted this change and it was merged.
Change subject: Also check wbIsEditView before enabling editing js
......................................................................
Also check wbIsEditView before enabling editing js
this is added in ViewEntityAction and checks if
the page is a diff or not current.
Bug: T95405
Change-Id: I9713fb75408dc0c8d2ff31ec9de42bbb4dcf9a0b
---
M repo/resources/wikibase.ui.entityViewInit.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Hoo man: Looks good to me, approved
jenkins-bot: Verified
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 9d5d7d8..475617c 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -16,7 +16,8 @@
var $entityview = $( '.wikibase-entityview' );
var entityInitializer = new wb.EntityInitializer( 'wbEntity' );
- var canEdit = !mw.config.get( 'wbUserIsBlocked' ) &&
mw.config.get( 'wbUserCanEdit' );
+ var canEdit = !mw.config.get( 'wbUserIsBlocked' ) &&
mw.config.get( 'wbUserCanEdit' )
+ && mw.config.get( 'wbIsEditView' );
if( canEdit ) {
initToolbarController( $entityview );
--
To view, visit https://gerrit.wikimedia.org/r/202692
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9713fb75408dc0c8d2ff31ec9de42bbb4dcf9a0b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
