Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/204108

Change subject: demo: Remove outline controls from outlined BookletLayout demo
......................................................................

demo: Remove outline controls from outlined BookletLayout demo

The demo does not implement any actions for them. Making them visible
and clickable, but doing nothing, makes the demo look broken.

Change-Id: Ic805cd3d43d283c1a418370f27270ec0251bd2f7
---
M demos/pages/dialogs.js
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/08/204108/1

diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index 12cf9f0..5760871 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -254,7 +254,6 @@
                OutlinedBookletDialog.super.prototype.initialize.apply( this, 
arguments );
                this.bookletLayout = new OO.ui.BookletLayout( {
                        outlined: true,
-                       editable: true,
                        menuSize: '15em'
                } );
                this.pages = [
@@ -265,7 +264,6 @@
                        new SamplePage( 'full', { label: 'Full', icon: 'window' 
} )
                ];
 
-               this.bookletLayout.getOutlineControls().setAbilities( { remove: 
false } );
                this.bookletLayout.addPages( this.pages );
                this.bookletLayout.connect( this, { set: 'onBookletLayoutSet' } 
);
                this.$body.append( this.bookletLayout.$element );

-- 
To view, visit https://gerrit.wikimedia.org/r/204108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic805cd3d43d283c1a418370f27270ec0251bd2f7
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to