jenkins-bot has submitted this change and it was merged.
Change subject: demo: Remove outline controls from outlined BookletLayout demo
......................................................................
demo: Remove outline controls from outlined BookletLayout demo
The demo does not implement any actions for them. Making them visible
and clickable, but doing nothing, makes the demo look broken.
Spotted by Kirsten when working on documentation.
Change-Id: Ic805cd3d43d283c1a418370f27270ec0251bd2f7
---
M demos/pages/dialogs.js
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js
index 12cf9f0..5760871 100644
--- a/demos/pages/dialogs.js
+++ b/demos/pages/dialogs.js
@@ -254,7 +254,6 @@
OutlinedBookletDialog.super.prototype.initialize.apply( this,
arguments );
this.bookletLayout = new OO.ui.BookletLayout( {
outlined: true,
- editable: true,
menuSize: '15em'
} );
this.pages = [
@@ -265,7 +264,6 @@
new SamplePage( 'full', { label: 'Full', icon: 'window'
} )
];
- this.bookletLayout.getOutlineControls().setAbilities( { remove:
false } );
this.bookletLayout.addPages( this.pages );
this.bookletLayout.connect( this, { set: 'onBookletLayoutSet' }
);
this.$body.append( this.bookletLayout.$element );
--
To view, visit https://gerrit.wikimedia.org/r/204108
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic805cd3d43d283c1a418370f27270ec0251bd2f7
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
