Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/204638

Change subject: Fix CentralAuthUser::loadAttached if no accounts are attached
......................................................................

Fix CentralAuthUser::loadAttached if no accounts are attached

Don't set $this->mAttachedArray to array( '' ) in that case...

php > var_dump( explode( "\n", '' ) );
array(1) {
  [0] =>
  string(0) ""
}

Bug: T96267
Change-Id: Ia541f514cd5a07e98a8f2a38d5584a0b95cf8634
(cherry picked from commit 70c69f38724c2d1b16be7837407c1d11d0db2364)
---
M includes/CentralAuthUser.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/38/204638/1

diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index da4b4aa..e2ad36d 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -1945,7 +1945,7 @@
                        return;
                }
 
-               if ( isset( $this->mAttachedList ) ) {
+               if ( isset( $this->mAttachedList ) && $this->mAttachedList !== 
'' ) {
                        // We have a list already, probably from the cache.
                        $this->mAttachedArray = explode( "\n", 
$this->mAttachedList );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/204638
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia541f514cd5a07e98a8f2a38d5584a0b95cf8634
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: wmf/1.26wmf1
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to