jenkins-bot has submitted this change and it was merged.
Change subject: Fix CentralAuthUser::loadAttached if no accounts are attached
......................................................................
Fix CentralAuthUser::loadAttached if no accounts are attached
Don't set $this->mAttachedArray to array( '' ) in that case...
php > var_dump( explode( "\n", '' ) );
array(1) {
[0] =>
string(0) ""
}
Bug: T96267
Change-Id: Ia541f514cd5a07e98a8f2a38d5584a0b95cf8634
(cherry picked from commit 70c69f38724c2d1b16be7837407c1d11d0db2364)
---
M includes/CentralAuthUser.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/CentralAuthUser.php b/includes/CentralAuthUser.php
index da4b4aa..e2ad36d 100644
--- a/includes/CentralAuthUser.php
+++ b/includes/CentralAuthUser.php
@@ -1945,7 +1945,7 @@
return;
}
- if ( isset( $this->mAttachedList ) ) {
+ if ( isset( $this->mAttachedList ) && $this->mAttachedList !==
'' ) {
// We have a list already, probably from the cache.
$this->mAttachedArray = explode( "\n",
$this->mAttachedList );
--
To view, visit https://gerrit.wikimedia.org/r/204639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia541f514cd5a07e98a8f2a38d5584a0b95cf8634
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: wmf/1.26wmf2
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
