Gilles has uploaded a new change for review.
https://gerrit.wikimedia.org/r/213807
Change subject: Explicitly define module position
......................................................................
Explicitly define module position
Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.
Bug: T97410
Change-Id: I8dbee3e4edf673341e7eb49f360e83e4dac54b17
---
M WikiEditor.php
M extension.json
2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikiEditor
refs/changes/07/213807/1
diff --git a/WikiEditor.php b/WikiEditor.php
index 6c61f31..62eee8a 100644
--- a/WikiEditor.php
+++ b/WikiEditor.php
@@ -417,6 +417,7 @@
),
),
'ext.wikiEditor.toolbar.styles' => $wikiEditorTpl + array(
+ 'position' => 'top',
'styles' => 'ext.wikiEditor.toolbar.styles.less',
),
'ext.wikiEditor.toolbar.hideSig' => $wikiEditorTpl + array(
diff --git a/extension.json b/extension.json
index b7cb391..5290618 100644
--- a/extension.json
+++ b/extension.json
@@ -398,6 +398,7 @@
]
},
"ext.wikiEditor.toolbar.styles": {
+ "position": "top",
"group": "ext.wikiEditor",
"styles": "ext.wikiEditor.toolbar.styles.less"
},
--
To view, visit https://gerrit.wikimedia.org/r/213807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dbee3e4edf673341e7eb49f360e83e4dac54b17
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
