jenkins-bot has submitted this change and it was merged.
Change subject: Explicitly define module position
......................................................................
Explicitly define module position
Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.
Bug: T97410
Change-Id: I8dbee3e4edf673341e7eb49f360e83e4dac54b17
---
M extension.json
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sbisson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 767263d..010c2e4 100644
--- a/extension.json
+++ b/extension.json
@@ -401,6 +401,7 @@
]
},
"ext.wikiEditor.toolbar.styles": {
+ "position": "top",
"group": "ext.wikiEditor",
"styles": "ext.wikiEditor.toolbar.styles.less"
},
--
To view, visit https://gerrit.wikimedia.org/r/213807
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dbee3e4edf673341e7eb49f360e83e4dac54b17
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikiEditor
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
