jenkins-bot has submitted this change and it was merged.
Change subject: Explicitly define filepage module position
......................................................................
Explicitly define filepage module position
Style modules currently added through addModuleStyles default
to being in the head ("top" position). This is an unhealthy default,
since only critical styles that are needed at pageload should be
in the head. In order to be able to switch the default to "bottom",
existing module positions have to be defined explicitly.
Bug: T97410
Change-Id: Id98b9eb46ef56a43bae99830f7db554c90073407
---
M resources/Resources.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index b0cd932..355502a 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -39,6 +39,7 @@
'group' => 'noscript',
),
'filepage' => array(
+ 'position' => 'top',
'class' => 'ResourceLoaderWikiModule',
'styles' => array( 'MediaWiki:Filepage.css' ),
),
--
To view, visit https://gerrit.wikimedia.org/r/213806
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id98b9eb46ef56a43bae99830f7db554c90073407
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gilles <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
