Jdlrobson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213985

Change subject: Icons in beta should be loaded via JavaScript
......................................................................

Icons in beta should be loaded via JavaScript

These icons are only needed for our JS users

Change-Id: I93d46795e0d56c1dabf483459474a1f91547b6d1
---
M includes/Resources.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/85/213985/1

diff --git a/includes/Resources.php b/includes/Resources.php
index f035b62..8e3dce1 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1774,6 +1774,7 @@
        'skins.minerva.beta.scripts' => $wgMFResourceFileModuleBoilerplate + 
array(
                'dependencies' => array(
                        'skins.minerva.scripts',
+                       'skins.minerva.beta.images',
                        // Feature modules that should be loaded in beta should 
be listed below here.
                        // These modules should only setup routes/events or
                        // load code under certain conditions.
diff --git a/includes/skins/SkinMinervaBeta.php 
b/includes/skins/SkinMinervaBeta.php
index b9639e3..8c8dadb 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -146,7 +146,6 @@
        protected function getSkinStyles() {
                $styles = parent::getSkinStyles();
                $styles[] = 'skins.minerva.beta.styles';
-               $styles[] = 'skins.minerva.beta.images';
                $styles[] = 'skins.minerva.tablet.beta.styles';
 
                return $styles;

-- 
To view, visit https://gerrit.wikimedia.org/r/213985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I93d46795e0d56c1dabf483459474a1f91547b6d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to