jenkins-bot has submitted this change and it was merged.
Change subject: Icons in beta should be loaded via JavaScript
......................................................................
Icons in beta should be loaded via JavaScript
These icons are only needed for our JS users
Bug: T100405
Change-Id: I93d46795e0d56c1dabf483459474a1f91547b6d1
---
M includes/Resources.php
M includes/skins/SkinMinervaBeta.php
2 files changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gilles: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Resources.php b/includes/Resources.php
index f035b62..8e3dce1 100644
--- a/includes/Resources.php
+++ b/includes/Resources.php
@@ -1774,6 +1774,7 @@
'skins.minerva.beta.scripts' => $wgMFResourceFileModuleBoilerplate +
array(
'dependencies' => array(
'skins.minerva.scripts',
+ 'skins.minerva.beta.images',
// Feature modules that should be loaded in beta should
be listed below here.
// These modules should only setup routes/events or
// load code under certain conditions.
diff --git a/includes/skins/SkinMinervaBeta.php
b/includes/skins/SkinMinervaBeta.php
index b9639e3..8c8dadb 100644
--- a/includes/skins/SkinMinervaBeta.php
+++ b/includes/skins/SkinMinervaBeta.php
@@ -146,7 +146,6 @@
protected function getSkinStyles() {
$styles = parent::getSkinStyles();
$styles[] = 'skins.minerva.beta.styles';
- $styles[] = 'skins.minerva.beta.images';
$styles[] = 'skins.minerva.tablet.beta.styles';
return $styles;
--
To view, visit https://gerrit.wikimedia.org/r/213985
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I93d46795e0d56c1dabf483459474a1f91547b6d1
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: Gilles <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
