jenkins-bot has submitted this change and it was merged.
Change subject: Log what job types were never inserted
......................................................................
Log what job types were never inserted
I am seeing a constant stream of
Notice: JobQueueGroup::__destruct: 1 buffered job(s) never inserted. in
/srv/mediawiki/php-1.26wmf6/includes/jobqueue/JobQueueGroup.php on line
419
In the production logfiles. Log what type of jobs these are so we can figure
out
how to fix them.
Change-Id: I7beca910d8c4b20aa20bdec4883e399fd94fbcfd
---
M includes/jobqueue/JobQueueGroup.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Aaron Schulz: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/jobqueue/JobQueueGroup.php
b/includes/jobqueue/JobQueueGroup.php
index 3d2393e..5bd1cc9 100644
--- a/includes/jobqueue/JobQueueGroup.php
+++ b/includes/jobqueue/JobQueueGroup.php
@@ -416,7 +416,8 @@
function __destruct() {
$n = count( $this->bufferedJobs );
if ( $n > 0 ) {
- trigger_error( __METHOD__ . ": $n buffered job(s) never
inserted." );
+ $type = implode( ', ', array_unique( array_map(
'get_class', $this->bufferedJobs ) ) );
+ trigger_error( __METHOD__ . ": $n buffered job(s) of
type(s) $type never inserted." );
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/214058
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7beca910d8c4b20aa20bdec4883e399fd94fbcfd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
