Dominic.sauer has submitted this change and it was merged. Change subject: Implemented further hints from review from Daniel. ......................................................................
Implemented further hints from review from Daniel. Bug: T100993 Change-Id: I92ef804e4c26c9f4b3f020f5b45b3c844e8b5f99 --- M WikibaseQualityExternalValidation.php M WikibaseQualityExternalValidationHooks.php R api/RunCrossCheck.php M composer.json M i18n/en.json M i18n/qqq.json D includes/ApiModuleFactory.php A includes/CrossCheck/ComparativeValueParser/BasicComparativeValueParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeGlobeCoordinateParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeMonolingualTextParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeMultilingualTextValueParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeQuantityParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeStringParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeStringValueParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeTimeParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeValueParser.php A includes/CrossCheck/ComparativeValueParser/ComparativeValueParserFactory.php A includes/CrossCheck/ComparativeValueParser/DispatchingComparativeValueParser.php M includes/CrossCheck/Comparer/DataValueComparer.php D includes/CrossCheck/Comparer/DataValueComparerBase.php M includes/CrossCheck/Comparer/DataValueComparerFactory.php M includes/CrossCheck/Comparer/DispatchingDataValueComparer.php M includes/CrossCheck/Comparer/EntityIdValueComparer.php M includes/CrossCheck/Comparer/GlobeCoordinateValueComparer.php M includes/CrossCheck/Comparer/MonolingualTextValueComparer.php M includes/CrossCheck/Comparer/MultilingualTextValueComparer.php M includes/CrossCheck/Comparer/QuantityValueComparer.php M includes/CrossCheck/Comparer/StringComparer.php M includes/CrossCheck/Comparer/StringValueComparer.php M includes/CrossCheck/Comparer/TimeValueComparer.php M includes/CrossCheck/CrossCheckInteractor.php M includes/CrossCheck/CrossChecker.php R includes/CrossCheck/ReferenceChecker.php R includes/CrossCheck/Result/ComparisonResult.php M includes/CrossCheck/Result/CrossCheckResult.php M includes/CrossCheck/Result/CrossCheckResultList.php M includes/CrossCheck/Result/ReferenceResult.php M includes/DumpMetaInformation/DumpMetaInformation.php A includes/DumpMetaInformation/DumpMetaInformationLookup.php D includes/DumpMetaInformation/DumpMetaInformationRepo.php A includes/DumpMetaInformation/DumpMetaInformationStore.php A includes/DumpMetaInformation/SqlDumpMetaInformationRepo.php M includes/EvaluateCrossCheckJob.php M includes/EvaluateCrossCheckJobService.php M includes/ExternalDataRepo.php R includes/ExternalValidationServices.php R includes/Serializer/ComparisonResultSerializer.php M includes/Serializer/CrossCheckResultSerializer.php M includes/Serializer/DumpMetaInformationSerializer.php M includes/Serializer/SerializerFactory.php D includes/SpecialPageFactory.php A includes/UpdateTable/ExternalDataImporter.php D includes/UpdateTable/Importer.php R includes/UpdateTable/TarImportSettings.php M includes/Violations/CrossCheckResultToViolationTranslator.php M includes/Violations/CrossCheckViolationFormatter.php M maintenance/UpdateTable.php M specials/SpecialCrossCheck.php M specials/SpecialExternalDbs.php M sql/create_wbqev_dump_information.sql R tests/phpunit/Api/RunCrossCheckTest.php D tests/phpunit/ApiModuleFactoryTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/BasicComparativeValueParserTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeMultilingualTextValueParserTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeStringValueParserTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeValueParserBaseTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/ComparativeValueParserFactoryTest.php A tests/phpunit/CrossCheck/ComparativeValueParser/DispatchingComparativeValueParserTest.php M tests/phpunit/CrossCheck/Comparer/DataValueComparerBaseTest.php M tests/phpunit/CrossCheck/Comparer/DataValueComparerFactoryTest.php M tests/phpunit/CrossCheck/Comparer/DispatchingDataValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/EntityIdValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/GlobeCoordinateValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/MonolingualTextValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/MultilingualTextValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/QuantityValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/StringComparerTest.php M tests/phpunit/CrossCheck/Comparer/StringValueComparerTest.php M tests/phpunit/CrossCheck/Comparer/TimeValueComparerTest.php D tests/phpunit/CrossCheck/Comparer/testdata/Q1.json M tests/phpunit/CrossCheck/CrossCheckerTest.php R tests/phpunit/CrossCheck/ReferenceCheckerTest.php M tests/phpunit/CrossCheck/Result/CompareResultTest.php M tests/phpunit/CrossCheck/Result/CrossCheckResultListTest.php M tests/phpunit/CrossCheck/Result/CrossCheckResultTest.php A tests/phpunit/CrossCheck/testdata/P227.json A tests/phpunit/CrossCheck/testdata/P228.json M tests/phpunit/DumpMetaInformation/DumpMetaInformationTest.php R tests/phpunit/DumpMetaInformation/SqlDumpMetaInformationRepoTest.php M tests/phpunit/EvaluateCrossCheckJobServiceTest.php M tests/phpunit/ExternalDataRepoTest.php R tests/phpunit/ExternalValidationServicesTest.php M tests/phpunit/Serializer/CompareResultSerializerTest.php M tests/phpunit/Serializer/CrossCheckResultSerializerTest.php M tests/phpunit/Serializer/SerializerFactoryTest.php D tests/phpunit/SpecialPageFactoryTest.php M tests/phpunit/Specials/SpecialCrossCheckTest.php M tests/phpunit/Specials/SpecialExternalDbsTest.php M tests/phpunit/UpdateTable/ImportContextTest.php M tests/phpunit/UpdateTable/UpdateTableTest.php M tests/phpunit/Violations/CrossCheckResultToViolationTranslatorTest.php M tests/phpunit/Violations/CrossCheckViolationFormatterTest.php 102 files changed, 3,770 insertions(+), 3,283 deletions(-) Approvals: Dominic.sauer: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/218636 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92ef804e4c26c9f4b3f020f5b45b3c844e8b5f99 Gerrit-PatchSet: 10 Gerrit-Project: mediawiki/extensions/WikidataQualityExternalValidation Gerrit-Branch: master Gerrit-Owner: Soeren.oldag <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Dominic.sauer <[email protected]> Gerrit-Reviewer: Legoktm <[email protected]> Gerrit-Reviewer: Siebrand <[email protected]> Gerrit-Reviewer: Soeren.oldag <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
